tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From spmalle...@apache.org
Subject tinkerpop git commit: TINKERPOP-1967 Removed some dead comments/code
Date Fri, 03 Aug 2018 10:52:20 GMT
Repository: tinkerpop
Updated Branches:
  refs/heads/TINKERPOP-1967 78e356909 -> 06af8c27a


TINKERPOP-1967 Removed some dead comments/code


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/06af8c27
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/06af8c27
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/06af8c27

Branch: refs/heads/TINKERPOP-1967
Commit: 06af8c27ad7bf51c8851ec52e46764359975b87a
Parents: 78e3569
Author: Stephen Mallette <spmva@genoprime.com>
Authored: Fri Aug 3 06:51:55 2018 -0400
Committer: Stephen Mallette <spmva@genoprime.com>
Committed: Fri Aug 3 06:51:55 2018 -0400

----------------------------------------------------------------------
 .../clustering/connected/ConnectedComponentVertexProgram.java | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/06af8c27/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/clustering/connected/ConnectedComponentVertexProgram.java
----------------------------------------------------------------------
diff --git a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/clustering/connected/ConnectedComponentVertexProgram.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/clustering/connected/ConnectedComponentVertexProgram.java
index 82907eb..acc8f3c 100644
--- a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/clustering/connected/ConnectedComponentVertexProgram.java
+++ b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/clustering/connected/ConnectedComponentVertexProgram.java
@@ -62,7 +62,6 @@ public class ConnectedComponentVertexProgram implements VertexProgram<String>
{
     public static final String COMPONENT = "gremlin.connectedComponentVertexProgram.component";
     private static final String PROPERTY = "gremlin.connectedComponentVertexProgram.property";
     private static final String EDGE_TRAVERSAL = "gremlin.pageRankVertexProgram.edgeTraversal";
-    private static final String HAS_HALTED = "gremlin.connectedComponentVertexProgram.hasHalted";
     private static final String VOTE_TO_HALT = "gremlin.connectedComponentVertexProgram.voteToHalt";
 
     private static final Set<MemoryComputeKey> MEMORY_COMPUTE_KEYS = Collections.singleton(MemoryComputeKey.of(VOTE_TO_HALT,
Operator.and, false, true));
@@ -122,11 +121,7 @@ public class ConnectedComponentVertexProgram implements VertexProgram<String>
{
             // for evaluation
             vertex.property(VertexProperty.Cardinality.single, property, vertex.id().toString());
 
-            // no need to send messages from traversers that were filtered - happens for
stuff like
-            // g.V().hasLabel('software').connectedComponent() (i.e. when there is a TraversalVertexProgram
in the mix
-            // halting traversers. only want to send messages from traversers that are still
hanging about after
-            // the filter. the unfiltered vertices can only react to messages sent to them.
of course, this can
-            // lead to weirdness in results. 
+            // vertices that have no edges remain in their own component - nothing to message
pass here
             if (vertex.edges(Direction.BOTH).hasNext()) {
                 // since there was message passing we don't want to halt on the first round.
this should only trigger
                 // a single pass finish if the graph is completely disconnected (technically,
it won't even really


Mime
View raw message