From commits-return-29243-archive-asf-public=cust-asf.ponee.io@tinkerpop.apache.org Mon May 21 12:58:30 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BD79A18063A for ; Mon, 21 May 2018 12:58:29 +0200 (CEST) Received: (qmail 61083 invoked by uid 500); 21 May 2018 10:58:28 -0000 Mailing-List: contact commits-help@tinkerpop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tinkerpop.apache.org Delivered-To: mailing list commits@tinkerpop.apache.org Received: (qmail 61069 invoked by uid 99); 21 May 2018 10:58:28 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 May 2018 10:58:28 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A3B32E0AD2; Mon, 21 May 2018 10:58:28 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: spmallette@apache.org To: commits@tinkerpop.apache.org Message-Id: <8fdfecf0029c47229fa90a5df51456e0@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: tinkerpop git commit: TINKERPOP-1968 Embedded list tests only pass for js at this point Date: Mon, 21 May 2018 10:58:28 +0000 (UTC) Repository: tinkerpop Updated Branches: refs/heads/TINKERPOP-1968 4d322a13a -> 29eef8977 TINKERPOP-1968 Embedded list tests only pass for js at this point Creating issues for .net and python. Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/29eef897 Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/29eef897 Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/29eef897 Branch: refs/heads/TINKERPOP-1968 Commit: 29eef8977a17955040b7c7921c1ebb20ed65325b Parents: 4d322a1 Author: Stephen Mallette Authored: Mon May 21 06:57:36 2018 -0400 Committer: Stephen Mallette Committed: Mon May 21 06:57:36 2018 -0400 ---------------------------------------------------------------------- .../Gherkin/GherkinTestRunner.cs | 5 ++++- .../Gherkin/IgnoreException.cs | 6 +++++- .../src/main/jython/radish/feature_steps.py | 2 +- gremlin-test/features/map/Select.feature | 18 +++++++++++++++++- gremlin-test/features/sideEffect/Group.feature | 1 - 5 files changed, 27 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/29eef897/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs ---------------------------------------------------------------------- diff --git a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs index 6d38ccc..d5eac93 100644 --- a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs +++ b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/GherkinTestRunner.cs @@ -38,7 +38,10 @@ namespace Gremlin.Net.IntegrationTest.Gherkin public class GherkinTestRunner { private static readonly IDictionary IgnoredScenarios = - new Dictionary(); + new Dictionary + { + { "g_V_asXa_bX_out_asXcX_path_selectXkeysX", IgnoreReason.EmbeddedListAssertion } + }; private static class Keywords { http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/29eef897/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/IgnoreException.cs ---------------------------------------------------------------------- diff --git a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/IgnoreException.cs b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/IgnoreException.cs index 860c11d..368713d 100644 --- a/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/IgnoreException.cs +++ b/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/IgnoreException.cs @@ -40,6 +40,9 @@ namespace Gremlin.Net.IntegrationTest.Gherkin string reasonSuffix = null; switch (reason) { + case IgnoreReason.EmbeddedListAssertion: + reasonSuffix = "This test returns an embedded list in the result and the Gherkin processor does not parse that correctly"; + break; case IgnoreReason.NoReason: reasonSuffix = ""; break; @@ -50,6 +53,7 @@ namespace Gremlin.Net.IntegrationTest.Gherkin public enum IgnoreReason { - NoReason + NoReason, + EmbeddedListAssertion } } \ No newline at end of file http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/29eef897/gremlin-python/src/main/jython/radish/feature_steps.py ---------------------------------------------------------------------- diff --git a/gremlin-python/src/main/jython/radish/feature_steps.py b/gremlin-python/src/main/jython/radish/feature_steps.py index fab35fd..5067d1b 100644 --- a/gremlin-python/src/main/jython/radish/feature_steps.py +++ b/gremlin-python/src/main/jython/radish/feature_steps.py @@ -43,7 +43,7 @@ inV = __.inV project = __.project tail = __.tail -ignores = [] +ignores = ["g.V().as(\"a\", \"b\").out().as(\"c\").path().select(Column.keys)"] @given("the {graph_name:w} graph") http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/29eef897/gremlin-test/features/map/Select.feature ---------------------------------------------------------------------- diff --git a/gremlin-test/features/map/Select.feature b/gremlin-test/features/map/Select.feature index 023b2a4..dffa464 100644 --- a/gremlin-test/features/map/Select.feature +++ b/gremlin-test/features/map/Select.feature @@ -658,4 +658,20 @@ Feature: Step - select() g.V().valueMap().select(Pop.all, "a","b") """ When iterated to list - Then the result should be empty \ No newline at end of file + Then the result should be empty + + Scenario: g_V_asXa_bX_out_asXcX_path_selectXkeysX + Given the modern graph + And the traversal of + """ + g.V().as("a", "b").out().as("c").path().select(Column.keys) + """ + When iterated to list + Then the result should be unordered + | result | + | l[l[a,b],l[c]] | + | l[l[a,b],l[c]] | + | l[l[a,b],l[c]] | + | l[l[a,b],l[c]] | + | l[l[a,b],l[c]] | + | l[l[a,b],l[c]] | \ No newline at end of file http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/29eef897/gremlin-test/features/sideEffect/Group.feature ---------------------------------------------------------------------- diff --git a/gremlin-test/features/sideEffect/Group.feature b/gremlin-test/features/sideEffect/Group.feature index 94d2191..cd2a5ce 100644 --- a/gremlin-test/features/sideEffect/Group.feature +++ b/gremlin-test/features/sideEffect/Group.feature @@ -161,7 +161,6 @@ Feature: Step - group() | ripple | | lop | - # TODO: can we change the traversal to allow for a better assertion Scenario: g_V_hasLabelXsongX_group_byXnameX_byXproperties_groupCount_byXlabelXX Given the grateful graph And the traversal of