tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rd...@apache.org
Subject [1/2] tinkerpop git commit: TINKERPOP-1833 Returned Builder object in DetachedEdge.Builder [Forced Update!]
Date Mon, 20 Nov 2017 12:27:52 GMT
Repository: tinkerpop
Updated Branches:
  refs/heads/TINKERPOP-1835 cdfcfbdaa -> 31d10401a (forced update)


TINKERPOP-1833 Returned Builder object in DetachedEdge.Builder

For some reason a couple of methods were returning void. Didn't see a good reason for that.
CTR


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/ec1cbda2
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/ec1cbda2
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/ec1cbda2

Branch: refs/heads/TINKERPOP-1835
Commit: ec1cbda2b70c8bf2628a853d151c2f5492460852
Parents: ca21532
Author: Stephen Mallette <spmva@genoprime.com>
Authored: Fri Nov 17 18:46:35 2017 -0500
Committer: Stephen Mallette <spmva@genoprime.com>
Committed: Fri Nov 17 18:46:35 2017 -0500

----------------------------------------------------------------------
 CHANGELOG.asciidoc                                             | 1 +
 .../gremlin/structure/util/detached/DetachedEdge.java          | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/ec1cbda2/CHANGELOG.asciidoc
----------------------------------------------------------------------
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index df00fa5..918bbd4 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -28,6 +28,7 @@ image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/ima
 * Fixed an `ArrayOutOfBoundsException` in `hasId()` for the rare situation when the provided
collection is empty.
 * Bump to Netty 4.0.52
 * `TraversalVertexProgram` `profile()` now accounts for worker iteration in `GraphComputer`
OLAP.
+* Returned the `Builder` instance from the `DetachedEdge.Builder` methods of `setOutE` and
`setOutV`.
 * Added a test for self-edges and fixed `Neo4jVertex` to provided repeated self-edges on
`BOTH`.
 * Better respected permissions on the `plugins.txt` file and prevented writing if marked
as read-only.
 * Added getters for the lambdas held by `LambdaCollectingBarrierStep`, `LambdaFlatMapStep`
and `LambdaSideEffectStep`.

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/ec1cbda2/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/detached/DetachedEdge.java
----------------------------------------------------------------------
diff --git a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/detached/DetachedEdge.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/detached/DetachedEdge.java
index 367dbc9..763dbb2 100644
--- a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/detached/DetachedEdge.java
+++ b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/detached/DetachedEdge.java
@@ -184,12 +184,14 @@ public class DetachedEdge extends DetachedElement<Edge> implements
Edge {
             return this;
         }
 
-        public void setOutV(final DetachedVertex v) {
+        public Builder setOutV(final DetachedVertex v) {
             e.outVertex = v;
+            return this;
         }
 
-        public void setInV(final DetachedVertex v) {
+        public Builder setInV(final DetachedVertex v) {
             e.inVertex = v;
+            return this;
         }
 
         public DetachedEdge create() {


Mime
View raw message