Mailing-List: contact commits-help@tinkerpop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tinkerpop.apache.org
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: spmallette@apache.org
To: commits@tinkerpop.apache.org
Date: Tue, 03 Oct 2017 18:21:04 -0000
Message-Id: <ec2f0d1653cc4d5298aaec1840d1d7b3@git.apache.org>
In-Reply-To: <7af166c3061e463ba91f87b7765660c0@git.apache.org>
References: <7af166c3061e463ba91f87b7765660c0@git.apache.org>
Subject: [19/26] tinkerpop git commit: TINKERPOP-1784 Added do nothings for
 unsupported tests
archived-at: Tue, 03 Oct 2017 18:20:50 -0000

TINKERPOP-1784 Added do nothings for unsupported tests


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/0b2fe19e
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/0b2fe19e
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/0b2fe19e

Branch: refs/heads/TINKERPOP-1784
Commit: 0b2fe19e98ba1e491615e8d17e2c887e25666018
Parents: 8ae2dd6
Author: Stephen Mallette <spmva@genoprime.com>
Authored: Sun Oct 1 07:28:31 2017 -0400
Committer: Stephen Mallette <spmva@genoprime.com>
Committed: Tue Oct 3 14:19:52 2017 -0400

----------------------------------------------------------------------
 .../src/main/jython/radish/feature_steps.py     |  2 +-
 gremlin-test/features/map/Vertex.feature        |  5 ++-
 .../features/sideEffect/GroupCount.feature      | 39 +++++++++-----------
 3 files changed, 23 insertions(+), 23 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/0b2fe19e/gremlin-python/src/main/jython/radish/feature_steps.py
----------------------------------------------------------------------
diff --git a/gremlin-python/src/main/jython/radish/feature_steps.py b/gremlin-python/src/main/jython/radish/feature_steps.py
index 340f84a..5b11ca1 100644
--- a/gremlin-python/src/main/jython/radish/feature_steps.py
+++ b/gremlin-python/src/main/jython/radish/feature_steps.py
@@ -82,7 +82,7 @@ def assert_result(step, characterized_as):
         raise ValueError("unknown data characterization of " + characterized_as)
 
 
-@then("nothing should happen")
+@then("nothing should happen because")
 def nothing_happening(step):
     return
 

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/0b2fe19e/gremlin-test/features/map/Vertex.feature
----------------------------------------------------------------------
diff --git a/gremlin-test/features/map/Vertex.feature b/gremlin-test/features/map/Vertex.feature
index 37e398b..1c9849e 100644
--- a/gremlin-test/features/map/Vertex.feature
+++ b/gremlin-test/features/map/Vertex.feature
@@ -420,7 +420,10 @@ Feature: Step - V(), E(), out(), in(), both(), inE(), outE(), bothE()
 
   Scenario: g_VX1_2_3_4X_name
     Given an unsupported test
-    Then nothing should happen
+    Then nothing should happen because
+      """
+      the test manipulates a static dataset which is not supported by the language of the feature files"
+      """
 
   Scenario: g_V_hasLabelXpersonX_V_hasLabelXsoftwareX_name
     Given the modern graph

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/0b2fe19e/gremlin-test/features/sideEffect/GroupCount.feature
----------------------------------------------------------------------
diff --git a/gremlin-test/features/sideEffect/GroupCount.feature b/gremlin-test/features/sideEffect/GroupCount.feature
index bfb7363..d68a964 100644
--- a/gremlin-test/features/sideEffect/GroupCount.feature
+++ b/gremlin-test/features/sideEffect/GroupCount.feature
@@ -17,7 +17,7 @@
 
 Feature: Step - groupCount()
 
-  Scenario: Group count vertices that have incoming created edges by their name
+  Scenario: g_V_outXcreatedX_groupCount_byXnameX
     Given the modern graph
     And the traversal of
       """
@@ -27,23 +27,20 @@ Feature: Step - groupCount()
     Then the result should be ordered
       | m[{"ripple": 1, "lop": 3}] |
 
-# NOT SUPPORTED UNTIL GRAPHSON 3.X WHICH HAS SUPPORT FOR NON-STRING KEYS
-#  Scenario: Edge count distribution
-#    Given the modern graph
-#    And the traversal of
-#      """
-#      g.V().groupCount().by(bothE().count())
-#      """
-#    When iterated to list
-#    Then the result should be ordered
-#      | m[{"d[1]": 3, "d[3]": 3}] |
-#
-#  Scenario: Group count vertices, cap to retrieve the map and unfold it to group count again
-#    Given the modern graph
-#    And the traversal of
-#      """
-#      g.V().both().groupCount("a").out().cap("a").select(Column.keys).unfold().both().groupCount("a").cap("a")
-#      """
-#    When iterated to list
-#    Then the result should be ordered
-#      | m[{"v[marko]": 6, "v[vadas]": 2, "v[lop]": 6, "v[josh]": 6, "v[ripple]": 2, "v[peter]": 2}] |
\ No newline at end of file
+  Scenario: g_V_groupCount_byXbothE_countX
+    Given an unsupported test
+    Then nothing should happen because
+      """
+      The result returned is not supported under GraphSON 2.x and therefore cannot be properly asserted. More
+      specifically it has vertex keys which basically get toString()'d under GraphSON 2.x. This test can be supported
+      with GraphSON 3.x.
+      """
+
+  Scenario: g_V_both_groupCountXaX_out_capXaX_selectXkeysX_unfold_both_groupCountXaX_capXaX
+    Given an unsupported test
+    Then nothing should happen because
+      """
+      The result returned is not supported under GraphSON 2.x and therefore cannot be properly asserted. More
+      specifically it has vertex keys which basically get toString()'d under GraphSON 2.x. This test can be supported
+      with GraphSON 3.x.
+      """
\ No newline at end of file