tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ok...@apache.org
Subject [49/50] tinkerpop git commit: Another problem with GraphSON 2.0. We really need type=g:Set, type=g:List, and type=g:Map. @dkuppitz was using a empty-set in a constant() and GraphSON 2.0 turns that into a list. Thus, when the Bytecode after GraphSON trans
Date Thu, 08 Dec 2016 22:54:15 GMT
Another problem with GraphSON 2.0. We really need type=g:Set, type=g:List, and type=g:Map.
@dkuppitz was using a empty-set in a constant() and GraphSON 2.0 turns that into a list. Thus,
when the Bytecode after GraphSON translation is compared with the Bytecode prior to translation,
the two bytecodes are different. @dkuppitz -- please make a note of this problem in our GraphSON
2.0 ticket.  CTR.


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/69b314cb
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/69b314cb
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/69b314cb

Branch: refs/heads/TINKERPOP-1564
Commit: 69b314cb2e52f33dbab29d3cddaadacb4ec69099
Parents: 6ec9648
Author: Marko A. Rodriguez <okrammarko@gmail.com>
Authored: Thu Dec 8 15:07:22 2016 -0700
Committer: Marko A. Rodriguez <okrammarko@gmail.com>
Committed: Thu Dec 8 15:07:22 2016 -0700

----------------------------------------------------------------------
 .../tinkerpop/gremlin/process/traversal/step/ComplexTest.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/69b314cb/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/ComplexTest.java
----------------------------------------------------------------------
diff --git a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/ComplexTest.java
b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/ComplexTest.java
index bbb6781..f13eafc 100644
--- a/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/ComplexTest.java
+++ b/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/ComplexTest.java
@@ -39,7 +39,7 @@ import java.util.Collection;
 import java.util.List;
 import java.util.Map;
 
-import static java.util.Collections.emptySet;
+import static java.util.Collections.emptyList;
 import static org.apache.tinkerpop.gremlin.process.traversal.P.eq;
 import static org.apache.tinkerpop.gremlin.process.traversal.P.neq;
 import static org.apache.tinkerpop.gremlin.process.traversal.Scope.local;
@@ -185,7 +185,7 @@ public abstract class ComplexTest extends AbstractGremlinProcessTest {
         public Traversal<Vertex, Map<String, Map<String, Map<String, Object>>>>
getCoworkerSummary() {
             return g.V().hasLabel("person").filter(outE("created")).aggregate("p").as("p1").values("name").as("p1n")
                     .select("p").unfold().where(neq("p1")).as("p2").values("name").as("p2n").select("p2")
-                    .out("created").choose(in("created").where(eq("p1")), values("name"),
constant(emptySet()))
+                    .out("created").choose(in("created").where(eq("p1")), values("name"),
constant(emptyList()))
                     .<String, Map<String, Map<String, Object>>>group().by(select("p1n")).
                             by(group().by(select("p2n")).
                                     by(unfold().fold().project("numCoCreated", "coCreated").by(count(local)).by()));


Mime
View raw message