tinkerpop-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ok...@apache.org
Subject tinkerpop git commit: fixed a severe bug where GraphComputer strategies were not being loaded until the second usage of the traversal source -- had to do with when static{} code blocks are initialized. dar. sucks. Work around is for the user to simply do
Date Mon, 24 Oct 2016 21:46:17 GMT
Repository: tinkerpop
Updated Branches:
  refs/heads/tp32 7bb0c90a0 -> b262c7ec4


fixed a severe bug where GraphComputer strategies were not being loaded until the second usage
of the traversal source -- had to do with when static{} code blocks are initialized. dar.
sucks. Work around is for the user to simply do SparkGraphComputer.class in their code prior
to using SparkGraphComputer (or whatever XXXGraphComptuer with registered strategies).


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/b262c7ec
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/b262c7ec
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/b262c7ec

Branch: refs/heads/tp32
Commit: b262c7ec475c2541d3f9af22fc9f9f57efa290a5
Parents: 7bb0c90
Author: Marko A. Rodriguez <okrammarko@gmail.com>
Authored: Mon Oct 24 15:46:11 2016 -0600
Committer: Marko A. Rodriguez <okrammarko@gmail.com>
Committed: Mon Oct 24 15:46:11 2016 -0600

----------------------------------------------------------------------
 CHANGELOG.asciidoc                                              | 4 ++--
 .../traversal/strategy/decoration/VertexProgramStrategy.java    | 5 +++++
 2 files changed, 7 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/b262c7ec/CHANGELOG.asciidoc
----------------------------------------------------------------------
diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
index 04b642e..4dee4c2 100644
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@ -23,10 +23,10 @@ TinkerPop 3.2.0 (Nine Inch Gremlins)
 image::https://raw.githubusercontent.com/apache/tinkerpop/master/docs/static/images/nine-inch-gremlins.png[width=185]
 
 [[release-3-2-4]]
-TinkerPop 3.2.5 (Release Date: NOT OFFICIALLY RELEASED YET)
+TinkerPop 3.2.4 (Release Date: NOT OFFICIALLY RELEASED YET)
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-
+* Fixed a severe bug where `GraphComputer` strategies are not being loaded until the second
use of the traversal source.
 
 [[release-3-2-3]]
 TinkerPop 3.2.3 (Release Date: October 17, 2016)

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/b262c7ec/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/strategy/decoration/VertexProgramStrategy.java
----------------------------------------------------------------------
diff --git a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/strategy/decoration/VertexProgramStrategy.java
b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/strategy/decoration/VertexProgramStrategy.java
index 89e40cb..0eeae3c 100644
--- a/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/strategy/decoration/VertexProgramStrategy.java
+++ b/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/strategy/decoration/VertexProgramStrategy.java
@@ -171,6 +171,11 @@ public final class VertexProgramStrategy extends AbstractTraversalStrategy<Trave
             }
         } else
             graphComputerClass = this.computer.getGraphComputerClass();
+        try {
+            Class.forName(graphComputerClass.getCanonicalName());
+        } catch (final ClassNotFoundException e) {
+            throw new IllegalStateException(e.getMessage(), e);
+        }
         final List<TraversalStrategy<?>> graphComputerStrategies = TraversalStrategies.GlobalCache.getStrategies(graphComputerClass).toList();
         traversalSource.getStrategies().addStrategies(graphComputerStrategies.toArray(new
TraversalStrategy[graphComputerStrategies.size()]));
     }


Mime
View raw message