tiles-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nicolas LE BAS <m...@nlebas.net>
Subject Re: Tiles Request API again
Date Sat, 10 Dec 2011 02:58:43 GMT
On 11-12-09 12:39 PM, Nicolas LE BAS wrote:
>> Also i notice that some of the diffs are awkward to read because of
>> whitespace changes on every line. I've also noticed you've removed the
>> apache license header from some files...
>> eg
>> https://github.com/nlebas/tiles/commit/78f6723a36cbfe607befd8621e9dc9354a954088#tiles-request/tiles-request-api/src/main/java/org/apache/tiles/request/Request.java
> hmm... Checkstyle should have caught that kind of mistake, I'll look
> into it. Obviously there's something wrong with my working environment,
> I'll fix it.

Well, with Checkstyle properly configured in eclipse, I could see the 
mess. Thanks for spotting it.
It should look better now on branch request-api2 (I've also included the 
renaming of WebRequest and the merging of TypeDetectectingRenderer).


View raw message