Return-Path: Delivered-To: apmail-tiles-dev-archive@locus.apache.org Received: (qmail 71505 invoked from network); 5 Apr 2007 15:31:44 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 Apr 2007 15:31:44 -0000 Received: (qmail 43629 invoked by uid 500); 5 Apr 2007 15:31:51 -0000 Delivered-To: apmail-tiles-dev-archive@tiles.apache.org Received: (qmail 43566 invoked by uid 500); 5 Apr 2007 15:31:51 -0000 Mailing-List: contact dev-help@tiles.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tiles.apache.org Delivered-To: mailing list dev@tiles.apache.org Received: (qmail 43522 invoked by uid 99); 5 Apr 2007 15:31:50 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Apr 2007 08:31:50 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of antonio.petrelli@gmail.com designates 66.249.82.226 as permitted sender) Received: from [66.249.82.226] (HELO wx-out-0506.google.com) (66.249.82.226) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Apr 2007 08:31:42 -0700 Received: by wx-out-0506.google.com with SMTP id h30so578327wxd for ; Thu, 05 Apr 2007 08:31:21 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=kD5FisktkgxXWh7KeDDbSNRbnD0q0AV1a8qsczWPmhOSCag43O5R1ajhXRqDEAo13EmnEYk5f6g6VoY/F+WGbUqi2+8HGCHeDr8zsFdXtJLR9xM+75TfYkRXlQ0zSL2gThDoYsxTmy0wvNux4SIC7pRCIU1Z3TS/SyO46AnkMtk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=XbwkvZXRfda9rPUq7DXByXaLVJeRHlcxjXjo8eaxcn5wDee+YacrdsYeUY8Asn5IbiWEs/k4EgzShpLnMzUTmuqdoaFH8fIxeNi9gv1sJEIsQ4P455SY++n4Y7HnG2HsZTDVSygOO28ZXS5fJ89ajySR1sjF0wgOGTEjbJO/q7I= Received: by 10.90.98.3 with SMTP id v3mr1711927agb.1175787080740; Thu, 05 Apr 2007 08:31:20 -0700 (PDT) Received: by 10.35.97.8 with HTTP; Thu, 5 Apr 2007 08:31:20 -0700 (PDT) Message-ID: Date: Thu, 5 Apr 2007 17:31:20 +0200 From: "Antonio Petrelli" To: dev@tiles.apache.org Subject: Checkstyle doubts MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Virus-Checked: Checked by ClamAV on apache.org Hi all! Besides the release process I am playing a bit with Checkstyle and its Eclipse plugin (eclipse-cs). There are some things that are configured in Struts checkstyle file that I am not convinced of: 1. The generics angular brackets must be surrounded by spaces. For me it is better to write: Map and not Map < K, V > 2. The "public" redundant modifier is declared illegal in that checkstyle file, but I think that it is not so bad. What do you think? Ciao Antonio P.S.: I'll be on holidays, I will return on Wednesday. So if anyone wants to collect the vote, finish the release etc., has my consensus to do it :-) Happy Easter!