tika-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amy...@apache.org
Subject svn commit: r1221493 - /tika/trunk/tika-parsers/src/test/java/org/apache/tika/mime/TestMimeTypes.java
Date Tue, 20 Dec 2011 21:16:36 GMT
Author: amylka
Date: Tue Dec 20 21:16:36 2011
New Revision: 1221493

URL: http://svn.apache.org/viewvc?rev=1221493&view=rev
Log:
TIKA-812 Clarified the javadoc of the test method I introduced with ver2 of my patch. In ver2
I added a magic which allows pure MimeTypes to detect works-spreadsheet files, but forgot
to update the javadoc for the text method. It was untrue. Now it's OK.

Modified:
    tika/trunk/tika-parsers/src/test/java/org/apache/tika/mime/TestMimeTypes.java

Modified: tika/trunk/tika-parsers/src/test/java/org/apache/tika/mime/TestMimeTypes.java
URL: http://svn.apache.org/viewvc/tika/trunk/tika-parsers/src/test/java/org/apache/tika/mime/TestMimeTypes.java?rev=1221493&r1=1221492&r2=1221493&view=diff
==============================================================================
--- tika/trunk/tika-parsers/src/test/java/org/apache/tika/mime/TestMimeTypes.java (original)
+++ tika/trunk/tika-parsers/src/test/java/org/apache/tika/mime/TestMimeTypes.java Tue Dec
20 21:16:36 2011
@@ -153,17 +153,12 @@ public class TestMimeTypes extends TestC
     /**
      * Files generated by Works 7.0 Spreadsheet application use the OLE2
      * structure and resemble Excel files (they contain a "Workbook"). They are
-     * not Excel though. The {@link POIFSContainerDetector} can detect them
-     * properly. With plain {@link MimeTypes} they are detected as Excel,
-     * because of the "Workbook" string. It's a problem we discussed in TIKA-806
-     * and agreed that we live with that. The policy is that container-based
-     * detection should trump magic-based detection. It's implemented in
-     * {@link DefaultDetector} (TIKA-786) and users who don't want to use to
-     * {@link DefaultDetector} should be aware of it.
+     * not Excel though. They are distinguished from Excel files with an
+     * additional top-level entry in below the root of the POI filesystem.
      * 
      * @throws Exception
      */
-    public void testWorks70Detection() throws Exception {
+    public void testWorksSpreadsheetDetection() throws Exception {
     	assertTypeDetection("testWORKSSpreadsheet7.0.xlr",
     			// with name-only, everything should be all right 
     			"application/x-tika-msworks-spreadsheet",



Mime
View raw message