thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [thrift] emmenlau opened a new pull request #2278: TServerSocket.cpp::isOpen(): Check that a domain socket really exists
Date Thu, 19 Nov 2020 10:38:32 GMT

emmenlau opened a new pull request #2278:

   There is a small chance that a server side domain socket file is not reported as existing
on the file system despite the server socket already being open. This can happen i.e. on Windows.
But its generally a good idea if the server checks for existence before reporting the socket
as being open. This helps i.e. with automatic testing, when clients must not try to connect
before the file exists.
   - [ ] Did you create an [Apache Jira](
ticket?  (not required for trivial changes)
   - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN:
describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label
the Jira ticket with "Breaking-Change"?
   - [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit
message to free up build resources.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message