thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [thrift] allengeorge opened a new pull request #2273: THRIFT-5306: Rust code and generated code no longer has clippy warnings (Rust 1.40)
Date Thu, 12 Nov 2020 13:36:08 GMT

allengeorge opened a new pull request #2273:
URL: https://github.com/apache/thrift/pull/2273


   Client: rs
   
   ## Specific changes (lib/check/tutorial/cross-test)
   
   * Update all `clippy`/`rustfmt` attributes to use new syntax
   * Use new numeric literal syntax
   * Use shorthand syntax for initializing structs
   * Use elided lifetimes for `Formatter`
   * Remove `extern crate`
   * Update all `Cargo.toml` files (except `lib/rs`) to remove direct references to `ordered-float`
crate (use Thrift redefinition)
   
   ## Specific changes (generator)
   
   * Remove unnecessary `()` return and `else` branch when writing fields
   * Use `_f64` suffix for float literals during const initialization
   * Take ownership of `self` when writing a Thrift enum (represented by a Rust enum with
integers) to an output protocol
   * Use shorthand syntax for initializing structs
   
   **NOTE**: This does _not_ fix any bugs. It simply updates the Rust code and generated code
so that it no longer prints clippy warnings, and uses Rust 2018 idioms.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message