From dev-return-59306-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Mon Oct 5 21:58:03 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 10A7618037A for ; Mon, 5 Oct 2020 23:58:03 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 45713121FC6 for ; Mon, 5 Oct 2020 21:58:02 +0000 (UTC) Received: (qmail 98257 invoked by uid 500); 5 Oct 2020 21:58:02 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 98229 invoked by uid 99); 5 Oct 2020 21:58:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Oct 2020 21:58:01 +0000 Received: from jira2-he-de.apache.org (static.54.33.119.168.clients.your-server.de [168.119.33.54]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1B34642AB3 for ; Mon, 5 Oct 2020 21:58:00 +0000 (UTC) Received: from jira2-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira2-he-de.apache.org (ASF Mail Server at jira2-he-de.apache.org) with ESMTP id 4F77FC81566 for ; Mon, 5 Oct 2020 21:58:00 +0000 (UTC) Date: Mon, 5 Oct 2020 21:58:00 +0000 (UTC) From: "Eric Gustavson (Jira)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (THRIFT-4181) PEP 484 Type Hinting on generated code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208360#comment-17208360 ] Eric Gustavson commented on THRIFT-4181: ---------------------------------------- +1 this would be very helpful as a user of generated thrift code > PEP 484 Type Hinting on generated code > -------------------------------------- > > Key: THRIFT-4181 > URL: https://issues.apache.org/jira/browse/THRIFT-4181 > Project: Thrift > Issue Type: New Feature > Components: Python - Compiler > Reporter: NEGORO Tetsuya > Priority: Minor > > Dear maintainers, > I think it is useful if Thrift Python compiler has option to enable generated code contain type hints proposed in PEP 484. > https://www.python.org/dev/peps/pep-0484 > Though it does no effect on semantics currently, there are several linting tools use it. It also helps people who work with generated code. > This syntax is supported by Python 3.5> only, but for versions below we can still use special type comments for annotations. > https://www.python.org/dev/peps/pep-0484/#suggested-syntax-for-python-2-7-and-straddling-code > Thanks -- This message was sent by Atlassian Jira (v8.3.4#803005)