thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jens Geyer (Jira)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-5299) rs implementation compact protocol seq_id should not use zigzag encoding.
Date Fri, 30 Oct 2020 07:50:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-5299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223479#comment-17223479
] 

Jens Geyer commented on THRIFT-5299:
------------------------------------

>  Also I issued a bug in integer-encoding crate, which the author also confirmed the problem

Good. Thanks. I was missing that piece of the puzzle.

>  you are the boss,

Very certainly not. But did you know you can become a "boss" too?
https://www.apache.org/foundation/getinvolved.html#become-a-committer


> rs implementation compact protocol seq_id should not use zigzag encoding.
> -------------------------------------------------------------------------
>
>                 Key: THRIFT-5299
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5299
>             Project: Thrift
>          Issue Type: Bug
>          Components: Rust - Library
>    Affects Versions: 0.13.0
>            Reporter: shuo li
>            Priority: Major
>
> While reviewing code, I discovered a bug in compact protocol.
> The seq_id in message header is decoded with integer-encoding's i32, which uses zigzag
decode implicitly. 
>  
>  
> EDIT: correct the title and desc.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message