thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jens Geyer (Jira)" <j...@apache.org>
Subject [jira] [Updated] (THRIFT-4942) Set PHP struct generated field values as private with getters and setters
Date Fri, 25 Sep 2020 20:04:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jens Geyer updated THRIFT-4942:
-------------------------------
    Labels: newbie pull-request-available  (was: Breaking-Change newbie pull-request-available)

> Set PHP struct generated field values as private with getters and setters
> -------------------------------------------------------------------------
>
>                 Key: THRIFT-4942
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4942
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Compiler
>    Affects Versions: 0.12.0
>         Environment: I'm using Ubuntu 18.04, applies to all platforms
>            Reporter: Dedipyaman Das
>            Priority: Minor
>              Labels: newbie, pull-request-available
>   Original Estimate: 0.5h
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> The PHP autogenerated code currently keeps the struct derived class attributes public,
and they have to be accessed like: $class->field.
> The java version keeps them private instead and uses getters and setters to access and
mutate the data.
> A similar approach would be a better choice for most oop based php coding standards. 
> I've created a working patch, so if I get approval I will create a Pull request for this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message