From dev-return-58862-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Fri Jun 26 14:12:44 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EE902180656 for ; Fri, 26 Jun 2020 16:12:43 +0200 (CEST) Received: (qmail 28856 invoked by uid 500); 26 Jun 2020 14:12:43 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 28844 invoked by uid 99); 26 Jun 2020 14:12:43 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jun 2020 14:12:43 +0000 From: =?utf-8?q?GitBox?= To: dev@thrift.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bthrift=5D_ResDiaryLewis_opened_a_new_pull_request_?= =?utf-8?q?=232188=3A_THRIFT-5329=3A_Add_THttpTransport_constructor_with_Htt?= =?utf-8?q?pClient?= Message-ID: Date: Fri, 26 Jun 2020 14:12:43 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ResDiaryLewis opened a new pull request #2188: URL: https://github.com/apache/thrift/pull/2188 Client: netstd - Added a new constructor `THttpTransport.cs` allowing the consumer to pass in their own `HttpClient` - Refactored the configuration of the `_httpClient` field so that both constructors will add standard headers to the client - Added a public static method to get a `HttpMessageHandler` with the same compression-decompression algorithms used by the previous constructor, this will allow users to create the client with the same behaviour as before - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org