thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [thrift] fishy opened a new pull request #2190: THRIFT-5240: Do connectivity check in Go server
Date Sat, 27 Jun 2020 17:17:29 GMT

fishy opened a new pull request #2190:

   Client: go
   In compiler generated TProcessorFunction implementations, add a
   goroutine after read the request to do connectivity check on the input
   transport. If the transport is no longer open, cancel the context object
   passed into the handler implementation.
   Also define ErrAbandonRequest error, to help TSimpleServer closing
   client connections that's already closed on the other end.
   <!-- Explain the changes in the pull request below: -->
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   - [x] Did you create an [Apache Jira](
ticket?  (not required for trivial changes)
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN:
describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label
the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit
message to free up build resources.
     The Contributing Guide at:
     has more details and tips for committing properly.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message