thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [thrift] ResDiaryLewis opened a new pull request #2188: THRIFT-5329: Add THttpTransport constructor with HttpClient
Date Fri, 26 Jun 2020 14:12:43 GMT

ResDiaryLewis opened a new pull request #2188:
URL: https://github.com/apache/thrift/pull/2188


   Client: netstd
   
   <!-- Explain the changes in the pull request below: -->
   - Added a new constructor `THttpTransport.cs` allowing the consumer to pass in their own
`HttpClient`
   - Refactored the configuration of the `_httpClient` field so that both constructors will
add standard headers to the client
   - Added a public static method to get a `HttpMessageHandler` with the same compression-decompression
algorithms used by the previous constructor, this will allow users to create the client with
the same behaviour as before
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/)
ticket?  (not required for trivial changes)
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN:
describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label
the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit
message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message