From dev-return-58601-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Mon May 25 15:18:04 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5F40418062C for ; Mon, 25 May 2020 17:18:04 +0200 (CEST) Received: (qmail 20180 invoked by uid 500); 25 May 2020 15:18:03 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 20168 invoked by uid 99); 25 May 2020 15:18:03 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 May 2020 15:18:03 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6A077E139A for ; Mon, 25 May 2020 15:18:02 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 23057780890 for ; Mon, 25 May 2020 15:18:00 +0000 (UTC) Date: Mon, 25 May 2020 15:18:00 +0000 (UTC) From: "Jonathan (Jira)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (THRIFT-5039) thrift npm package should be published from root folder MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-5039?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D171= 16109#comment-17116109 ]=20 Jonathan edited comment on THRIFT-5039 at 5/25/20, 3:17 PM: ------------------------------------------------------------ [~emmenlau] Sorry for the late reply. I installed it to take a look. Indeed it does seem to solve the one issue h= ere, which is that the browser runtime wasn't bundled. I am sure the other = issues you fixed are good fixes to make too, but I can't verify them withou= t knowing what they are. I also don't know why anything else should need to be included for this one= very critical issue with the npm package being completely broken on its la= test version, when it would only take a republish of 0.13.0 from the proper= directory of the repo. The only issue here is that the browser js runtime = simply was not published at all to 0.13.0 on npm, and the fix is very simpl= e, it just needs publisher access to the npm package. It's easy to see the correct version of the package working fine if you jus= t do {{npm add git://github.com/apache/thrift.git#v0.13.0}} instead of {{np= m add thrift @0.13.0}}.=C2=A0 How do we reach someone with publisher access and the time to address this? was (Author: jrajav): [~emmenlau] Sorry for the late reply. I installed it to take a look. Indeed it does seem to solve the one issue h= ere, which is that the browser runtime wasn't bundled. I am sure the other = issues you fixed are good fixes to make too, but I can't verify them withou= t knowing what they are. I also don't know why anything else should need to be included for this one= very critical issue with the npm package being completely broken on its la= test version, when it would only take a republish of 0.13.0 from the proper= directory of the repo. The only issue here is that the browser js runtime = simply was not published at all to 0.13.0 on npm, and the fix is very simpl= e, it just needs publisher access to the npm package. It's easy to see the correct version of the package working fine if you jus= t do {{npm add git://github.com/apache/thrift.git#v0.13.0}} instead of {{np= m add thrift @0.13.0}}. And this issue will continue to exist forever if it= isn't addressed by republishing 0.13.0 - simply publishing a new version w= ill only plaster over it, but will not support downgrades or client/server = version matching. How do we reach someone with publisher access and the time to address this? > thrift npm package should be published from root folder > ------------------------------------------------------- > > Key: THRIFT-5039 > URL: https://issues.apache.org/jira/browse/THRIFT-5039 > Project: Thrift > Issue Type: Bug > Components: Node.js - Library > Affects Versions: 0.13.0 > Reporter: Soner Okur > Assignee: James E. King III > Priority: Critical > Original Estimate: 1h > Remaining Estimate: 1h > > Thrift npm package was published from js folder. Therefore, we can't buil= d our software because lack of nodejs library. Can you re-publish the packa= ge ? -- This message was sent by Atlassian Jira (v8.3.4#803005)