thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [thrift] ulidtko opened a new pull request #2151: THRIFT-5186: Rewrite address resolution in T{Nonblocking,}ServerSocket
Date Thu, 21 May 2020 09:30:16 GMT

ulidtko opened a new pull request #2151:
URL: https://github.com/apache/thrift/pull/2151


   This is in followup to #2124. Passing `AI_ADDRCONFIG` hint to `getaddrinfo()` breaks Thrift
servers when there's no network (127.0.0.1 loopback only). *Not passing* `AI_ADDRCONFIG` exposes
deficient logic of processing `getaddrinfo()` results. This PR fixes the latter.
   
   Please see the commit messages for the details of why&how.
   
   I'm also including a quick drive-by fix of a compile warning related to Boost.Test deprecations,
as a separate commit.
   
   Since I only tested on Linux — am very keen to see what AppVeyor and Travis CI's will
have to say about this change (hopefully, some errors which point out my blunders).
   
   Meanwhile — anyone interested is welcome to review. @emmenlau I think you'd want to take
a look; this patch certainly needs another pair of eyes.
   
   - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/)
ticket?  (not required for trivial changes)
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN:
describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label
the Jira ticket with "Breaking-Change"?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message