thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duru Can Celasun (Jira)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-5205) Tag prior releases with "v" prefix for compatibility with go.mod
Date Tue, 12 May 2020 16:00:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-5205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105554#comment-17105554
] 

Duru Can Celasun commented on THRIFT-5205:
------------------------------------------

I think doing "go get library@revision" only in libA would solve your problem.

> the leaf repositories cannot inherit this restriction since it's not a constraint that
Go modules can follow

Are you sure? I'm not aware of anything in the module spec that says this. Can you share a
repo, even a dummy one, to reproduce this problem?

> Tag prior releases with "v" prefix for compatibility with go.mod
> ----------------------------------------------------------------
>
>                 Key: THRIFT-5205
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5205
>             Project: Thrift
>          Issue Type: Wish
>          Components: Go - Library
>    Affects Versions: 0.10.0, 0.11.0
>            Reporter: Prashant V
>            Priority: Minor
>
> Thrift 0.13.0 uses the tag "v0.13.0", while prior releases do not have the "v" prefix.
Is it possible to add an additional tag "v0.10.0", "v0.11.0", etc for older releases so that
Go modules works correctly with them, see [https://github.com/golang/go/issues/32945]
>  
> We have some projects that use older versions and can't update due to the breaking changes
where ctx was added as a parameter, so need to use old versions, but would still like to use
go.mod.
>  
> Adding additional tags (the old ones should still be valid) would help unblock usage
of Go modules.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message