From dev-return-58410-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Thu Apr 30 15:45:19 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6C374180630 for ; Thu, 30 Apr 2020 17:45:19 +0200 (CEST) Received: (qmail 99252 invoked by uid 500); 30 Apr 2020 15:45:18 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 99240 invoked by uid 99); 30 Apr 2020 15:45:18 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Apr 2020 15:45:18 +0000 From: =?utf-8?q?GitBox?= To: dev@thrift.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bthrift=5D_fishy_opened_a_new_pull_request_=232128?= =?utf-8?q?=3A_THRIFT-5164=3A_Small_cleanup_on_the_example_code?= Message-ID: Date: Thu, 30 Apr 2020 15:45:18 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit fishy opened a new pull request #2128: URL: https://github.com/apache/thrift/pull/2128 Client: go Godoc requires at least one other exported type/function to render the whole example file in the example, so export simpleProcessorLoggingMiddleware to make the example of ProcessorMiddleware more helpful. Currently it's rendered in a not very helpful way: https://pkg.go.dev/github.com/apache/thrift@v0.13.1-0.20200430141240-5cffef964a08/lib/go/thrift?tab=doc#example-ProcessorMiddleware Compare to the client middleware example rendering: https://pkg.go.dev/github.com/apache/thrift@v0.13.1-0.20200430141240-5cffef964a08/lib/go/thrift?tab=doc#example-ClientMiddleware While I'm here, also update CHANGES.md to mention ClientMiddleware. - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? - [x] Did you squash your changes to a single commit? (not required, but preferred) - [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"? - [x] If your change does not involve any code, add ` [skip ci]` at the end of your pull request to free up build resources. [skip ci] ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org