From dev-return-58183-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Mon Apr 20 05:39:11 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E9672180634 for ; Mon, 20 Apr 2020 07:39:10 +0200 (CEST) Received: (qmail 99115 invoked by uid 500); 20 Apr 2020 05:39:10 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 99103 invoked by uid 99); 20 Apr 2020 05:39:09 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Apr 2020 05:39:09 +0000 From: =?utf-8?q?GitBox?= To: dev@thrift.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bthrift=5D_janosvitok_commented_on_issue_=232100=3A?= =?utf-8?q?_Update_the_libthrift=2Evcxproj_and_libthrift=2Evcxproj=2Efilters?= =?utf-8?q?_file?= Message-ID: <158736114990.29173.6960207757020469070.asfpy@gitbox.apache.org> Date: Mon, 20 Apr 2020 05:39:09 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: janosvitok commented on issue #2100: URL: https://github.com/apache/thrift/pull/2100#issuecomment-616322575 These changes improve the project files, but do not fix it completely. There are more files to be removed and some files to be added. I'd suggest removing visual studio solution completely, and use cmake to generate them when needed. They seem to be pretty unmaintained anyway. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org