thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [thrift] emmenlau opened a new pull request #2105: THRIFT-5178: Added constructor with default host localhost
Date Mon, 20 Apr 2020 12:32:38 GMT

emmenlau opened a new pull request #2105:
URL: https://github.com/apache/thrift/pull/2105


   The constructors for THttpClient require specifying a `host`. However not all supported
socket types require a host. I.e. when using a Unix domain socket, the host is required to
be localhost.
   
   This PR adds a constructor that avoids host in the signature, and sets the value to `localhost`.
   
   - [x] Did you create an https://issues.apache.org/jira/browse/THRIFT-5178 ticket?  (not
required for trivial changes)
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN:
describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label
the Jira ticket with "Breaking-Change"?
   - [x] If your change does not involve any code, add ` [skip ci]` at the end of your pull
request to free up build resources.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message