thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Bléher (Jira) <j...@apache.org>
Subject [jira] [Commented] (THRIFT-5173) Thrift C# (netstd) code generator: make method virtual for mocking
Date Tue, 14 Apr 2020 18:56:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-5173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083531#comment-17083531
] 

Eric Bléher commented on THRIFT-5173:
-------------------------------------

It is a bit difficult to test the performance difference in my application.

An alternative proposal would be to *optionally* generate the method virtual, i.e. with a
flag in the generator cmd.

> Thrift C# (netstd) code generator: make method virtual for mocking
> ------------------------------------------------------------------
>
>                 Key: THRIFT-5173
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5173
>             Project: Thrift
>          Issue Type: Improvement
>          Components: netstd - Compiler
>    Affects Versions: 0.13.0
>            Reporter: Eric Bléher
>            Priority: Major
>
> Thrift compiler generates C# clients where methods cannot be mocked because they are
not defined as virtual.
> Adding virtual allow the usage of Moq and thus I can have proper unit tests of my own
class implementations consuming theses generated clients.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message