thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jano Svitok (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (THRIFT-5109) Misc CMake improvements
Date Wed, 15 Apr 2020 06:50:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17083853#comment-17083853
] 

Jano Svitok edited comment on THRIFT-5109 at 4/15/20, 6:49 AM:
---------------------------------------------------------------

Another guess: npm install complains about vulnerable packages.
I'd guess that npm install calls npm audit and that emits non-zero exit code that aborts the
whole cmake custom build.
Try to append {{|| cd .}} (https://stackoverflow.com/a/54880482) the the npm install command
to check if that is the case.
If it indeed is, most probably another PR is needed to fix those packages (npm audit fix).

Disclaimer: I'm just guessing here :-)

{code}
Building Javascript library using npm + Grunt Wrapper
  
  > puppeteer@1.11.0 install C:\projects\thrift\lib\js\node_modules\puppeteer
  > node install.js
  
  
  Chromium downloaded to C:\projects\thrift\lib\js\node_modules\puppeteer\.local-chromium\win32-609904
  added 474 packages from 306 contributors and audited 2466 packages in 22.232s
  
  3 packages are looking for funding
    run `npm fund` for details
  
  found 85 vulnerabilities (57 low, 4 moderate, 24 high)
    run `npm audit fix` to fix them, or `npm audit` for details
  Building Javascript library using npm + Grunt Wrapper
  Running "shell:InstallThriftJS" (shell) task
  >> The syntax of the command is incorrect.
CUSTOMBUILD : warning : Done, with errors: command "mkdir -p test/build/js/lib; cp src/thrift.js
test/build/js/thrift.js" (target "InstallThriftJS") exited with code 1. Use --force to continue.
[C:\projects\build\MSVC2015\x86\lib\js\ThriftJavascript.vcxproj]
  
  Aborted due to warnings.
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 6. [C:\projects\build\MSVC2015\x86\lib\js\ThriftJavascript.vcxproj]
  Installing NodeJS dependencies with npm
  
  > utf-8-validate@5.0.2 install C:\projects\thrift\node_modules\utf-8-validate
  > node-gyp-build
  
  added 380 packages from 267 contributors and audited 932 packages in 12.75s
  
  8 packages are looking for funding
    run `npm fund` for details
  
  found 7 vulnerabilities (6 low, 1 moderate)
    run `npm audit fix` to fix them, or `npm audit` for details
{code}


was (Author: janosvitok):
Another guess: npm install complains about vulnerable packages.
I'd guess that npm install calls npm audit and that emits non-zero exit code that aborts the
whole cmake custom build.
Try to append {{|| cd .}} the the npm install command to check if that is the case.
If it indeed is, most probably another PR is needed to fix those packages (npm audit fix).

Disclaimer: I'm just guessing here :-)

{code}
Building Javascript library using npm + Grunt Wrapper
  
  > puppeteer@1.11.0 install C:\projects\thrift\lib\js\node_modules\puppeteer
  > node install.js
  
  
  Chromium downloaded to C:\projects\thrift\lib\js\node_modules\puppeteer\.local-chromium\win32-609904
  added 474 packages from 306 contributors and audited 2466 packages in 22.232s
  
  3 packages are looking for funding
    run `npm fund` for details
  
  found 85 vulnerabilities (57 low, 4 moderate, 24 high)
    run `npm audit fix` to fix them, or `npm audit` for details
  Building Javascript library using npm + Grunt Wrapper
  Running "shell:InstallThriftJS" (shell) task
  >> The syntax of the command is incorrect.
CUSTOMBUILD : warning : Done, with errors: command "mkdir -p test/build/js/lib; cp src/thrift.js
test/build/js/thrift.js" (target "InstallThriftJS") exited with code 1. Use --force to continue.
[C:\projects\build\MSVC2015\x86\lib\js\ThriftJavascript.vcxproj]
  
  Aborted due to warnings.
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 6. [C:\projects\build\MSVC2015\x86\lib\js\ThriftJavascript.vcxproj]
  Installing NodeJS dependencies with npm
  
  > utf-8-validate@5.0.2 install C:\projects\thrift\node_modules\utf-8-validate
  > node-gyp-build
  
  added 380 packages from 267 contributors and audited 932 packages in 12.75s
  
  8 packages are looking for funding
    run `npm fund` for details
  
  found 7 vulnerabilities (6 low, 1 moderate)
    run `npm audit fix` to fix them, or `npm audit` for details
{code}

> Misc CMake improvements
> -----------------------
>
>                 Key: THRIFT-5109
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5109
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Build Process
>            Reporter: Jens Geyer
>            Assignee: Mario Emmenlauer
>            Priority: Major
>             Fix For: 0.14.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
>  * compiler/cpp/CMakeLists.txt: Install compiler after build, like automake does
>  * Added NodeJS to cmake build
>  * Added Javascript to cmake build
>  * build/cmake/DefineInstallationPaths.cmake: fixed the library path
>  * build/cmake/ThriftMacros.cmake: do not enforce debug suffix 'd' 
>  * lib/java/CMakeLists.txt: allow to override JAVA_INSTALL_DIR 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message