thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mario Emmenlauer (Jira)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-5109) Misc CMake improvements
Date Thu, 09 Apr 2020 07:23:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17079004#comment-17079004
] 

Mario Emmenlauer commented on THRIFT-5109:
------------------------------------------

I may need help with a small issue, or otherwise I'll put that aside for the current PR.

Everything seems to work in CI now, except for one problem: [https://ci.appveyor.com/project/ApacheSoftwareFoundation/thrift/builds/32052666/job/9yt639vjkbdwxj2h]
{code}
CMake Error at lib/js/cmake_install.cmake:56 (file):
file INSTALL cannot find "C:/projects/thrift/lib/js/doc": No such file or directory.
{code}
 
In the CMakeLists.txt I call "grunt-cli jsdoc" explicitly, which builds the docs for me. I
can't see why that does not work on appveyor. Are there special output directories set for
grunt or npm?

> Misc CMake improvements
> -----------------------
>
>                 Key: THRIFT-5109
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5109
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Build Process
>            Reporter: Jens Geyer
>            Assignee: Mario Emmenlauer
>            Priority: Major
>             Fix For: 0.14.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
>  * compiler/cpp/CMakeLists.txt: Install compiler after build, like automake does
>  * Added NodeJS to cmake build
>  * Added Javascript to cmake build
>  * build/cmake/DefineInstallationPaths.cmake: fixed the library path
>  * build/cmake/ThriftMacros.cmake: do not enforce debug suffix 'd' 
>  * lib/java/CMakeLists.txt: allow to override JAVA_INSTALL_DIR 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message