thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jens Geyer" <jensge...@hotmail.com>
Subject Re: Travis CI builds broken?
Date Sat, 04 Apr 2020 12:21:59 GMT
Hi,

> PHP composer [...] API rate limited.

Do any of the PHP people an idea how to overcome (or circumvent) that? I 
mean, other than committing some secret data to a public repository.

> ThriftTest/Xception.cs(51,29): warning CS0114: 'Xception.Message' hides 
> inherited member 'Exception.Message'.

Known issue, there's also a ticket for it. Nothing serious but yeah, should 
be addressed.

Have fun,
JensG


-----Urspr√ľngliche Nachricht----- 
From: Jano Svitok
Sent: Friday, April 3, 2020 5:32 PM
To: dev@thrift.apache.org
Subject: Re: Travis CI builds broken?

On 3. Apr 20 16:41, James Lacey wrote:
> Both of my pull requests (THRIFT-5156 and THRIFT-5159) have failed their
> Travis CI builds, but when I go to look at the failures, they happened in
> languages that I did not change. In fact, the failure on THRIFT-5156 is
> especially weird because the builds passed on my first commit, but failed
> on the second commit which made some minor changes to casts. The errors I
> see in the logs are for PHP, Ruby or .NET Standard. I am continuing to try
> to reproduce the failures, but so far I have not been able to. Other than
> that, I am not sure where to go from here.

THRIFT-5159 failures are the same as 
https://issues.apache.org/jira/browse/THRIFT-5151
I quickly tried to search for a solution, but didn't find any.

The problem seems to be that PHP composer pulls packages from github using 
API rather than public URI,
and the API is rate limited. Since travis runs lot of jobs it hits the limit 
from time to time.

There are some recommendations on the net, I can't tell which one would 
work.

THRIFT-5156: I was not able to reproduce the bundle install not in gzip 
format problem

This seems to be something that can be fixed in code (unrelated to your 
changes):

ThriftTest/Xception.cs(51,29): warning CS0114: 'Xception.Message' hides 
inherited member 'Exception.Message'.
To make the current member override that implementation, add the override 
keyword. Otherwise add the new keyword. 
[/thrift/src/test/netstd/Server/Server.csproj]
ThriftTest/Xception.cs(51,29): warning CS0114: 'Xception.Message' hides 
inherited member 'Exception.Message'.
To make the current member override that implementation, add the override 
keyword. Otherwise add the new keyword. 
[/thrift/src/test/netstd/Client/Client.csproj]

I'd say other failures are network-related.

J.
-- 
Jan Svitok | jsv@whitestein.com
Whitestein Technologies s.r.o. | www.whitestein.com
Karadzicova 12 | 821 08 Bratislava | Slovak Republic
Main +421 2 5443-5502 | Direct +421 2 5930-0735 | Fax +421 2 5443-5512 


Mime
View raw message