thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jano Svitok (Jira)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-5084) Swift: Server-side support for Multiplexing Services
Date Thu, 05 Mar 2020 17:28:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052362#comment-17052362
] 

Jano Svitok commented on THRIFT-5084:
-------------------------------------

I suppose that FileHandle.acceptConnectionInBackgroundAndNotify() is present in iOS/OSX swift
("apple proprietary") since ages, this problem affects linux only ("open source swift"; that
means for example tests in CI). For linux CI images it certainly makes sense to upgrade swift
to latest swift. I can't tell about osx images. Is it possible run swift unit tests and cross
tests swift-* and *-swift there?

> Swift: Server-side support for Multiplexing Services
> ----------------------------------------------------
>
>                 Key: THRIFT-5084
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5084
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Swift - Library
>    Affects Versions: 0.13.0
>            Reporter: Alexander Edge
>            Assignee: Alexander Edge
>            Priority: Blocker
>              Labels: multiplex
>             Fix For: 0.14.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The Swift library features {{TMultiplexedProtocol}} but not {{TMultiplexedProcessor}},
which is required for use server-side.
> I've added {{TMultiplexedProcessor}}, following the same patterns as the other language
libraries. -I've marked this issue as _Breaking-Change_ since it removes the {{associatedType}}
from the {{TProcessor}} protocol-. I've removed the {{associatedType}} from {{TProcessor}} otherwise
it makes it impossible for {{TMultiplexedProcessor}} to implement {{TProcessor}}. By definition
it should support processors of multiple services, not a single service.
> I've added tests which require a change to {{Package.swift}} to run using {{swift test}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message