thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan (Jira)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-5039) thrift npm package should be published from root folder
Date Tue, 10 Mar 2020 15:27:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-5039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056060#comment-17056060
] 

Jonathan commented on THRIFT-5039:
----------------------------------

Hi [~jensg] / [~jking3] or anyone who has npm maintainer access - it appears that what has
gone wrong here is that someone has mistakenly published the `thrift` npm package using the
'js' folder [https://github.com/apache/thrift/blob/master/lib/js/package.json] when it should
be the one at the project root that properly includes and references both the browser and
Node versions and their module roots: [https://github.com/apache/thrift/blob/master/package.json]

I appreciate that this is an open source project and you all have other commitments first,
but this is a complete production blocker - it has broken every single Node.js project using
Thrift with the latest npm version, for these past months. For instance, anyone trying to
get up and running for the first time with your Node.js examples. And the fix seems likely
to be quite simple - maybe as simple as running `npm publish` from the root directory on the
0.13.0 tag after.

> thrift npm package should be published from root folder
> -------------------------------------------------------
>
>                 Key: THRIFT-5039
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5039
>             Project: Thrift
>          Issue Type: Bug
>          Components: JavaScript - Library
>    Affects Versions: 0.13.0
>            Reporter: Soner Okur
>            Assignee: James E. King III
>            Priority: Critical
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Thrift npm package was published from js folder. Therefore, we can't build our software
because lack of nodejs library. Can you re-publish the package ?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message