thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zezeng Wang (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (THRIFT-4272) warnings in glibc library
Date Tue, 24 Mar 2020 10:58:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17065512#comment-17065512
] 

Zezeng Wang edited comment on THRIFT-4272 at 3/24/20, 10:57 AM:
----------------------------------------------------------------

*testtransportsslsocket.c:530:21: warning: initializer-string for char array is*
 *too long*
 *guchar match[10] = TEST_DATA;*
                                   *^~~~~~~~~*
 *testtransportsslsocket.c:35:21: note: expanded from macro 'TEST_DATA'*
 *#define TEST_DATA \{ "GET / HTTP/1.1\n\n" }*

                                    *^~~~~~~~~~~~~~~~~~~~*

 

I didn't occur this warning in my environment, but it seems that *TEST_DATA* 's length

is over 10...  maybe it's need to expand the size of array *match* .


was (Author: zeshuai007):
*testtransportsslsocket.c:530:21: warning: initializer-string for char array is*
 *too long*
 *guchar match[10] = TEST_DATA;*
                                   *^~~~~~~~~*
 *testtransportsslsocket.c:35:21: note: expanded from macro 'TEST_DATA'*
 *#define TEST_DATA \{ "GET / HTTP/1.1\n\n" }*

I didn't occur this warning in my environment, but it seems that *TEST_DATA* 's length

is over 10...  maybe it's need to expand the size of array *match* .

> warnings in glibc library
> -------------------------
>
>                 Key: THRIFT-4272
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4272
>             Project: Thrift
>          Issue Type: Bug
>          Components: C glib - Library
>            Reporter: Jens Geyer
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Travis emits a gazillion of warnings during glib-c builds. Amongst some compatibility
related things there are some quite interesting ones:
> {code}
> testtransportsslsocket.c:530:21: warning: initializer-string for char array is
>       too long
>         guchar match[10] = TEST_DATA;
>                            ^~~~~~~~~
> testtransportsslsocket.c:35:21: note: expanded from macro 'TEST_DATA'
> #define TEST_DATA { "GET / HTTP/1.1\n\n" }
>                     ^~~~~~~~~~~~~~~~~~~~
> {code}
> and
> {code}
> src/thrift/c_glib/transport/thrift_ssl_socket.c:147:10: warning: implicit
>       declaration of function 'thrift_socket_is_open' is invalid in C99
>       [-Wimplicit-function-declaration]
>   return thrift_socket_is_open(transport);
>          ^
> src/thrift/c_glib/transport/thrift_ssl_socket.c:179:8: warning: implicit
>       declaration of function 'thrift_socket_open' is invalid in C99
>       [-Wimplicit-function-declaration]
>   if (!thrift_socket_open(transport, error)) {
>        ^
> src/thrift/c_glib/transport/thrift_ssl_socket.c:185:7: warning: implicit
>       declaration of function 'thrift_socket_close' is invalid in C99
>       [-Wimplicit-function-declaration]
>       thrift_socket_close(transport, &tmperr);
>       ^
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message