thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Edge (Jira)" <j...@apache.org>
Subject [jira] [Updated] (THRIFT-5084) Swift: Server-side support for Multiplexing Services
Date Wed, 05 Feb 2020 17:12:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alexander Edge updated THRIFT-5084:
-----------------------------------
    Description: 
The Swift library features {{TMultiplexedProtocol}} but not {{TMultiplexedProcessor}}, which
is required for use server-side.

I've added {{MultiplexedProcessor}}, following the same patterns as the other language libraries.
I've marked the JIRA issue as _Breaking-Change_ since it removes the {{associatedType}} from
the {{TProcessor}} protocol. Since the existing {{TProcessor}} definition uses an {{associatedType
}}, it makes it impossible for {{MultiplexedProcessor}} to implement {{TProcessor}}. By definition
it should support processors of multiple services, not a single service.

I've added tests which require a change to {{Package.swift}} to run using {{swift test}}.

  was:
The Swift library features TMultiplexedProtocol but not TMultiplexedProcessor, which is required
for use server-side.

 

The pull-request via GitHub adds this functionality along with tests.


> Swift: Server-side support for Multiplexing Services
> ----------------------------------------------------
>
>                 Key: THRIFT-5084
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5084
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Swift - Library
>    Affects Versions: 0.13.0
>            Reporter: Alexander Edge
>            Priority: Minor
>              Labels: Breaking-Change, multiplex
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The Swift library features {{TMultiplexedProtocol}} but not {{TMultiplexedProcessor}},
which is required for use server-side.
> I've added {{MultiplexedProcessor}}, following the same patterns as the other language
libraries. I've marked the JIRA issue as _Breaking-Change_ since it removes the {{associatedType}}
from the {{TProcessor}} protocol. Since the existing {{TProcessor}} definition uses an {{associatedType
}}, it makes it impossible for {{MultiplexedProcessor}} to implement {{TProcessor}}. By definition
it should support processors of multiple services, not a single service.
> I've added tests which require a change to {{Package.swift}} to run using {{swift test}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message