From dev-return-57555-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Thu Jan 30 01:44:02 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 82C57180667 for ; Thu, 30 Jan 2020 02:44:02 +0100 (CET) Received: (qmail 54078 invoked by uid 500); 30 Jan 2020 01:44:01 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 54057 invoked by uid 99); 30 Jan 2020 01:44:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Jan 2020 01:44:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 95C3FE2E0A for ; Thu, 30 Jan 2020 01:44:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 12AE17801F3 for ; Thu, 30 Jan 2020 01:44:00 +0000 (UTC) Date: Thu, 30 Jan 2020 01:44:00 +0000 (UTC) From: "Jens Geyer (Jira)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (THRIFT-5079) Required fields need to be verified before write MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-5079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5079: ------------------------------- Summary: Required fields need to be verified before write (was: [CPP] Required fields need to be verified before write) > Required fields need to be verified before write > ------------------------------------------------ > > Key: THRIFT-5079 > URL: https://issues.apache.org/jira/browse/THRIFT-5079 > Project: Thrift > Issue Type: Bug > Components: C++ - Compiler > Affects Versions: 0.13.0 > Reporter: Christopher Friedt > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > It seems as though the 'required' keyword is not really enforced at least in C++ and possibly Python for v0.13.0. There are a few tickets there already. THRIFT-4946, THRIFT-5041, THRIFT-735, THRIFT-4241, THRIFT-455. > I don't mind providing a simple fix for C++ and an additional test case, but there should be an effort to look through whether or not this is broken across other languages / generator targets. -- This message was sent by Atlassian Jira (v8.3.4#803005)