thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jens Geyer (Jira)" <j...@apache.org>
Subject [jira] [Resolved] (THRIFT-5074) Cleanup test suite command line options
Date Thu, 23 Jan 2020 22:32:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-5074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jens Geyer resolved THRIFT-5074.
--------------------------------
    Fix Version/s: 0.14.0
       Resolution: Fixed

I've took the liberty to make some changes compared to the existing reality in code. 

In particular, the {{multi}} approach (like in {{multic}} and  {{multij}}) does not scale
(besides it is also hard to read). It mixes protocols and layered transports and that just
makes no sense. Hence, I removed them and added {{--multiplexed}} switch instead.

I'm not fully sure about {{header}} either, but I left it for now. IMHO that construct should
be a simple layered transport as well, on top of either binary or whatever else is chosen.
Instead it comes with its own protocol infrastructure which makes it an unnecessarily complex,
double-headed beast that is at the same time inflexible enough to not even support anything
besides the two hardcoded options compact and binary.

> Cleanup test suite command line options
> ---------------------------------------
>
>                 Key: THRIFT-5074
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5074
>             Project: Thrift
>          Issue Type: Documentation
>          Components: Documentation
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>            Priority: Minor
>             Fix For: 0.14.0
>
>         Attachments: 0001-THRIFT-5074-Cleanup-of-test-suite-command-line-optio.patch
>
>
> The test suite command line options are slightly outdated and should be maintained.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message