thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Neves (Jira)" <j...@apache.org>
Subject [jira] [Reopened] (THRIFT-4702) Improve AutoExpandingBuffer
Date Tue, 28 Jan 2020 19:48:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Paulo Neves reopened THRIFT-4702:
---------------------------------

> Actually, they probably shouldn't be interacting with those either. Only with {{TFastFramedTransport}}.

If this is the case then the AutoExpand* classes should also be internal, and currently they
are not. This is misleading as they seem usable except they are not.  I believe either the
"internalization" should be finished or reverted

> Improve AutoExpandingBuffer
> ---------------------------
>
>                 Key: THRIFT-4702
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4702
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>    Affects Versions: 0.12.0
>            Reporter: David Mollitor
>            Assignee: James E. King III
>            Priority: Minor
>              Labels: Breaking-Change
>             Fix For: 0.13.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The class has a concept of a "growth factor" which is a float value.  However, the growth
value is hard-coded at 150%.  Instead, remove this configurable value, that isn't externally
configurable, and instead use bit shifting to achieve a 150% increase instead of a a float
value.
> Decrease the scope of this class since it is an internal utility and should not be directly
consumed by outside code.
> Other miscellaneous cleanup and simplification.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message