thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jens Geyer (Jira)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4889) Add SASL support for non-blocking server
Date Thu, 12 Dec 2019 07:57:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994354#comment-16994354
] 

Jens Geyer commented on THRIFT-4889:
------------------------------------

I am aware of that. Well, the PR was open quite some time, not getting much feedback. In my
experience the feedback will come as soon as people start using it. 

What I have seen in my review looked good to me, you covered lots of the implementation with
test cases and I did not really find anything to complain on. One of the arraycopy() statements
might be slightly questionable - it is indeed correct, but I would probably have placed an
assert() before it to make sure the premises hold, but that's about the only thing that I
could find. Additionally, as you wrote above, the code is also (sort of) battle-tested already.


Again, feedback will come as soon as people start using it. Let's look forward to it.

> Add SASL support for non-blocking server
> ----------------------------------------
>
>                 Key: THRIFT-4889
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4889
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Java - Library
>            Reporter: Qinghui Xu
>            Assignee: Qinghui Xu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.14.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, it seems the sasl is available only for blocking server. But in some circumstances
the server cannot handle the workload/nb of connections with the blocking IO, we need SASL
support to secure the non-blocking IO servers in such situations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message