thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jens Geyer (Jira)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-5032) Allows PascalCase properties for netstd
Date Wed, 27 Nov 2019 01:29:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-5032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983068#comment-16983068
] 

Jens Geyer commented on THRIFT-5032:
------------------------------------

> What the current version of thrift does is, when you have a StructThing in the .thrift
file it actually generates properties like Struct_thing

Yeah, I noticed that, and I also thought about undoing that "feature". Just didn't have the
time, it's not a high-prio issue to me.

> Allows PascalCase properties for netstd
> ---------------------------------------
>
>                 Key: THRIFT-5032
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5032
>             Project: Thrift
>          Issue Type: Improvement
>          Components: netstd - Compiler
>            Reporter: Paulo Neves
>            Assignee: Paulo Neves
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Microsoft guidelines  state that public properties should be PascalCase. Currently if
a property in the thrift description is MyProperty it will be expanded into My_property which
is clearly wrong. As this is a breaking change I added a pascal option to the netstd generator.
I believe that in the future this should be the default and the old style deprecated.
> I also added the option to the generator of the Server test, so that we can have a test
with the properties in PascalCase talking with a netstd client without PascalCase. I hope
this is ok.
>  
> https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/capitalization-conventions



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message