thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jens Geyer (Jira)" <j...@apache.org>
Subject [jira] [Issue Comment Deleted] (THRIFT-5032) Allows PascalCase properties for netstd
Date Mon, 25 Nov 2019 21:39:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-5032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jens Geyer updated THRIFT-5032:
-------------------------------
    Comment: was deleted

(was: Make it the default. We don't need an option for this. The wire format is compatible,
maybe some code must be changed. But with the port to netstd30 this is required anyway. )

> Allows PascalCase properties for netstd
> ---------------------------------------
>
>                 Key: THRIFT-5032
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5032
>             Project: Thrift
>          Issue Type: Improvement
>          Components: netstd - Compiler
>            Reporter: Paulo Neves
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Microsoft guidelines  state that public properties should be PascalCase. Currently if
a property in the thrift description is MyProperty it will be expanded into My_property which
is clearly wrong. As this is a breaking change I added a pascal option to the netstd generator.
I believe that in the future this should be the default and the old style deprecated.
> I also added the option to the generator of the Server test, so that we can have a test
with the properties in PascalCase talking with a netstd client without PascalCase. I hope
this is ok.
>  
> https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/capitalization-conventions



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message