thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jens Geyer (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (THRIFT-5032) Allows PascalCase properties for netstd
Date Mon, 25 Nov 2019 21:37:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-5032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981908#comment-16981908
] 

Jens Geyer edited comment on THRIFT-5032 at 11/25/19 9:36 PM:
--------------------------------------------------------------

But ... yes, there's a but. I always wondered if modifying to whatever casing style at all
is really such a great idea. It may give you conflicts. My personal opinion would be that
we use whatever we get from the IDL file as closely as possible. But that really would break
a whole bunch of code.

What Microsoft recommends may still not fit your or my use case. After all it is a recommendation
not the ten commandments.


was (Author: jensg):
But ... yes, there's a but. I always wondered if modifying to whatever casing style at all
is really such a great idea. It may give you conflicts. My personal opinion would be that
we use whatever we get from the IDL file as closely as possible. But that really would break
a whole bunch of code.

> Allows PascalCase properties for netstd
> ---------------------------------------
>
>                 Key: THRIFT-5032
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5032
>             Project: Thrift
>          Issue Type: Improvement
>          Components: netstd - Compiler
>            Reporter: Paulo Neves
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Microsoft guidelines  state that public properties should be PascalCase. Currently if
a property in the thrift description is MyProperty it will be expanded into My_property which
is clearly wrong. As this is a breaking change I added a pascal option to the netstd generator.
I believe that in the future this should be the default and the old style deprecated.
> I also added the option to the generator of the Server test, so that we can have a test
with the properties in PascalCase talking with a netstd client without PascalCase. I hope
this is ok.
>  
> https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/capitalization-conventions



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message