thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Seaborne (Jira)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-5022) TIOStreamTransport.isOpen is false for InputStream or Outpstream only use.
Date Wed, 20 Nov 2019 21:21:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-5022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978737#comment-16978737
] 

Andy Seaborne commented on THRIFT-5022:
---------------------------------------

[~q.xu] Thank you for the quick response.

I've just done [PR #1942|https://github.com/apache/thrift/pull/1942] that turns the "&&"
into an "||" on whether either inputStream_ or outputStream_ is non-null.  

close() already clears inputStream_ or outputStream_.

So this is equivalent to a flag for "isOpen" without the additional field.

Your suggestion would be to catch Throwable in close()? I can add that is that helps.

> TIOStreamTransport.isOpen is false for InputStream or Outpstream only use.
> --------------------------------------------------------------------------
>
>                 Key: THRIFT-5022
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5022
>             Project: Thrift
>          Issue Type: Task
>          Components: Java - Library
>    Affects Versions: 0.13.0
>            Reporter: Andy Seaborne
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> This follows from THRIFT-2530.
> {{TIOStreamTransaport.isOpen}} changed to be
>  
> {noformat}
>   public boolean isOpen() {
>     return inputStream_ != null && outputStream_ != null;
>   }
> {noformat}
> but constructors {{TIOStreamTransaport(InputStream)}} and {{TIOStreamTransaport(OutputStream)}}
leave one of {{inputStream_}} or {{outputStream_}} null.
> This makes isOpen false immediately, no close() called. open() does not change the state
of object.
>  Example:
> {noformat}
> TIOStreamTransport x1 = new TIOStreamTransport(new ByteArrayInputStream(new byte[1]));
>  System.out.println(x1.isOpen());
>  TIOStreamTransport x2 = new TIOStreamTransport(new ByteArrayOutputStream());
>  System.out.println(x2.isOpen());
> {noformat}
> is prints false both times.
>  
> It should be:
> {noformat}
>   public boolean isOpen() {
>     return inputStream_ != null || outputStream_ != null;
>   }
> {noformat}
> or an explicit flag for the open/close state but {{inputStream_ != null || outputStream_
!= null;}} is enough given the current close implementation.
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message