thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jens Geyer (Jira)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-5010) BinaryPrimitives.Read/WriteInt32BigEndian should be used to convert to/from network byte order
Date Tue, 19 Nov 2019 21:11:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-5010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16977834#comment-16977834
] 

Jens Geyer commented on THRIFT-5010:
------------------------------------

We already reference certain MS packages from nuget, so that is fine. If you need help with
your PR, please ask.

> BinaryPrimitives.Read/WriteInt32BigEndian should be used to convert to/from network byte
order
> ----------------------------------------------------------------------------------------------
>
>                 Key: THRIFT-5010
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5010
>             Project: Thrift
>          Issue Type: Improvement
>          Components: netstd - Library
>    Affects Versions: 0.13.0
>            Reporter: Edward Zhuravlov
>            Priority: Major
>              Labels: features
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Conversion -should be- _from/to TCP protocol format (always big-Endian) to execution
engine_ based on processor architecture. See System.BitConverter class ():
> [https://docs.microsoft.com/en-us/dotnet/api/system.bitconverter?view=netstandard-2.0]
>  ??The endianness of an architecture is indicated by the [IsLittleEndian|https://docs.microsoft.com/en-us/dotnet/api/system.bitconverter.islittleendian?view=netframework-4.8]
property, which returns {{true}} on little-endian systems and {{false}} on big-endian systems.
On little-endian systems, lower-order bytes precede higher-order bytes. On big-endian system,
higher-order bytes precede lower-order bytes. ??
> Recomended use BinaryPrimitives.WriteInt32BigEndian/ReadInt32BigEndian class from nuget
System.Memory by Microsoft for NetStandard 2.0.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message