thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Boiles (Jira)" <j...@apache.org>
Subject [jira] [Updated] (THRIFT-5002) Golang: remote client fails to compile when extending services
Date Sat, 09 Nov 2019 00:14:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-5002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

John Boiles updated THRIFT-5002:
--------------------------------
    Description: 
For example, for this test case (also available in [github.com/johnboiles/golang-fix-container-struct-remote|https://github.com/johnboiles/thrift/tree/golang-fix-container-struct-remote])
{code}
service container_test_base {
    void setfunc(1: set<i32> s)
}

service container_test extends container_test_base {
}
{code}

This error occurs when compiling the Go code
{code}
gopath/src/servicestest/container_test-remote/container_test-remote.go:163:25: undefined:
servicestest.NewContainerTestSetfuncArgs
{code}

That is because there is no generated code for {{NewContainerTestSetfuncArgs}} but instead
only {{NewContainerTestBaseSetfuncArgs}}. We should probably fix this either by also generating
{{NewContainerTestSetfuncArgs}} or using {{NewContainerTestBaseSetfuncArgs}} from the remote
client for the derived service.

  was:
For example, for this test case
{code}
service container_test_base {
    void setfunc(1: set<i32> s)
}

service container_test extends container_test_base {
}
{code}

This error occurs when compiling the Go code
{code}
gopath/src/servicestest/container_test-remote/container_test-remote.go:163:25: undefined:
servicestest.NewContainerTestSetfuncArgs
{code}

That is because there is no generated code for {{NewContainerTestSetfuncArgs}} but instead
only {{NewContainerTestBaseSetfuncArgs}}. We should probably fix this either by also generating
{{NewContainerTestSetfuncArgs}} or using {{NewContainerTestBaseSetfuncArgs}} from the remote
client for the derived service.


> Golang: remote client fails to compile when extending services
> --------------------------------------------------------------
>
>                 Key: THRIFT-5002
>                 URL: https://issues.apache.org/jira/browse/THRIFT-5002
>             Project: Thrift
>          Issue Type: Task
>          Components: Go - Compiler
>    Affects Versions: 0.13.0
>            Reporter: John Boiles
>            Priority: Major
>
> For example, for this test case (also available in [github.com/johnboiles/golang-fix-container-struct-remote|https://github.com/johnboiles/thrift/tree/golang-fix-container-struct-remote])
> {code}
> service container_test_base {
>     void setfunc(1: set<i32> s)
> }
> service container_test extends container_test_base {
> }
> {code}
> This error occurs when compiling the Go code
> {code}
> gopath/src/servicestest/container_test-remote/container_test-remote.go:163:25: undefined:
servicestest.NewContainerTestSetfuncArgs
> {code}
> That is because there is no generated code for {{NewContainerTestSetfuncArgs}} but instead
only {{NewContainerTestBaseSetfuncArgs}}. We should probably fix this either by also generating
{{NewContainerTestSetfuncArgs}} or using {{NewContainerTestBaseSetfuncArgs}} from the remote
client for the derived service.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message