thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jens Geyer (Jira)" <j...@apache.org>
Subject [jira] [Resolved] (THRIFT-4919) THttpTransport.cs (netstd) and THttpClientTransport (netcore) have bad timeout code
Date Tue, 20 Aug 2019 19:37:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jens Geyer resolved THRIFT-4919.
--------------------------------
    Fix Version/s: 0.13.0
       Resolution: Fixed

> THttpTransport.cs (netstd) and THttpClientTransport (netcore) have bad timeout code
> -----------------------------------------------------------------------------------
>
>                 Key: THRIFT-4919
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4919
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.12.0
>            Reporter: Al Tam
>            Assignee: Jens Geyer
>            Priority: Major
>             Fix For: 0.13.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> THttpTransport.cs (netstd) and THttpClientTransport (netcore) have the same identical
and badly written timeout configuration code.
>  # the code is using Timespan.FromSeconds(), yet the coder wants the variable to be using
milliseconds
>  # the timeout is permanently set to the class initialized value since the timeout is
only used within constructor, rendering the property useless
> Incidentally, there's no way to configure timeout except for using reflection.
> Also, if the ConnectTimeout property is NOT readable, how can people determine what's
used for the timeout?  It should be readable too.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Mime
View raw message