thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jens Geyer" <je...@apache.org>
Subject Re: Adding a new language to Thrift
Date Thu, 29 Aug 2019 19:35:05 GMT
Hi,

I am a bit worried by the statement "The basics were done by someone else 
here". The project linked is under a MIT style license, and you are not the 
original author. The ASF usually requires the contributor of the source 
(which would be you) contributed to an ASF project to have adequate rights 
to do so. I'd doubt that you can simply take someone elses code and 
contribute it under APL 2. Even if we talk about OSS, that is questionable.

Would it be an option to ask the original owner of the code whether he/she 
wants to contribute the code him/herself and put the contribution under APL 
2?

Have fun,
JensG


-----Ursprüngliche Nachricht----- 
From: Roberts, Geoffry [USA]
Sent: Thursday, August 29, 2019 9:06 PM
To: user@thrift.apache.org
Subject: Adding a new language to Thrift

All,

I am trying to add the Julia language to Thrift.  The basics were done by 
someone else here<https://github.com/tanmaykm/Thrift.jl>. Follow the link it 
states,  “Place Julia plugin 
t_jl_generator.cc<https://github.com/tanmaykm/Thrift.jl/tree/master/compiler> 
into compiler/cpp/src/generate folder. Update makefiles to include the new 
source and rebuild.”  I have done that but my language is not getting built.

I am updating the.file:

thrift-0.12.0/compiler/cpp/Makefile.am

like this:

82 thrift_SOURCES += src/thrift/generate/t_c_glib_generator.cc \

<other languages>

src/thrift/generate/t_cl_generator.cc \
                 src/thrift/generate/t_jl_generator.cc    // Julia added 
here.

I run ./configure and see among other things:

Building C (GLib) Library .... : no
Building C# (Mono) Library ... : no
Building C++ Library ......... : yes
Building Common Lisp Library.. : no
Building D Library ........... : no
Building Dart Library ........ : no
Building dotnetcore Library .. : no
Building Erlang Library ...... : no
Building Go Library .......... : yes
Building Haskell Library ..... : no
Building Haxe Library ........ : no
Building Java Library ........ : no
Building Lua Library ......... : no
Building NodeJS Library ...... : yes
Building Perl Library ........ : yes
Building PHP Library ......... : yes
Building Plugin Support ...... : no
Building Python Library ...... : yes
Building Py3 Library ......... : no
Building Ruby Library ........ : no
Building Rust Library ........ : no

Julia is not even listed much less being built.

Is there anything else I need to do? 


Mime
View raw message