thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Can Celasun (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4908) reader&writer in golang's TBinaryProtocol is not necessary and misleading
Date Sun, 14 Jul 2019 12:05:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884655#comment-16884655
] 

Can Celasun commented on THRIFT-4908:
-------------------------------------

Please send a PR on Github and I'll take a look.

> reader&writer in golang's TBinaryProtocol is not necessary and misleading
> -------------------------------------------------------------------------
>
>                 Key: THRIFT-4908
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4908
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Library
>    Affects Versions: 0.12.0
>            Reporter: CHENG GUOZHU
>            Priority: Minor
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> while reading code in [https://github.com/apache/thrift/blob/master/lib/go/thrift/binary_protocol.go]
> It seems the reader and writer in TBinaryProtocol is not necessary, because this class
is serialize/deserialize the struct and write/read the data stream via trans, `reader` &
`writer` here are duplicated with `trans` in this struct
> if it's meaningful, I will submit a patch for this



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message