thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kyle Smith (JIRA)" <>
Subject [jira] [Commented] (THRIFT-4820) Remove unnecessary NuGet dependency from netstd
Date Thu, 14 Mar 2019 12:09:00 GMT


Kyle Smith commented on THRIFT-4820:

Ah. I simply removed the dependency and confirmed it would build but didn't try running it
through our custom ASP.NET Core middleware.

Splitting out the HTTP component into a separate package would have the benefit of a smaller
core package plus open up support for non-Core hosting providers. With a dedicated package
you could create a dedicated solution without polluting the core library. This could include
an actual middleware tie-in (e.g. app.UseThrift("/rpc") and service.UseThrift()).

Overall I like the idea of having separate packages for heavier pieces.

> Remove unnecessary NuGet dependency from netstd
> -----------------------------------------------
>                 Key: THRIFT-4820
>                 URL:
>             Project: Thrift
>          Issue Type: Improvement
>          Components: netstd - Library
>    Affects Versions: 0.12.0
>            Reporter: Kyle Smith
>            Priority: Minor
> You should be able to remove the dependency on the heavy Microsoft.AspNetCore package.
THttpServerTransport doesn't utilize anything outside the Microsoft.AspNetCore.Http.Abstractions

This message was sent by Atlassian JIRA

View raw message