thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King III (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (THRIFT-4752) Add cmake package configuration support?
Date Fri, 15 Mar 2019 11:36:00 GMT

     [ https://issues.apache.org/jira/browse/THRIFT-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James E. King III closed THRIFT-4752.
-------------------------------------
    Resolution: Duplicate
      Assignee: James E. King III

> Add cmake package configuration support?
> ----------------------------------------
>
>                 Key: THRIFT-4752
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4752
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Deployment
>            Reporter: Mario Emmenlauer
>            Assignee: James E. King III
>            Priority: Trivial
>              Labels: cmake
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The thrift build with cmake is really great! In my daily use, there is a minor issue
left: downstream packages all have to have a FindThrift.cmake script. This is slightly annoying,
because it replicates the same detection script over and over in all downstream packages.
> Modern cmake suggests a nice solution: the use of package configuration files (see
[https://cmake.org/cmake/help/v3.0/manual/cmake-packages.7.html#package-configuration-file).] With
package configuration files, after building thrift, downstream packages can just use
> {noformat}
> find_package(thrift){noformat}
> and the library and compiler are "auto-magically" resolved. Transitive package dependencies
are also resolved, and even build settings like compiler flags can be passed on.
> I have created a package configuration for thrift cmake build. Could this be considered
for inclusion?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message