thrift-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James E. King III (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (THRIFT-4804) Add only PHP code to the packagist.org composer package
Date Mon, 18 Feb 2019 16:15:00 GMT

    [ https://issues.apache.org/jira/browse/THRIFT-4804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16771187#comment-16771187
] 

James E. King III commented on THRIFT-4804:
-------------------------------------------

Nice.  Pull requests are encouraged. :)  I'm not aware of any other uses of this git attribute. 
If it pops up during a release, we'll have to adjust.  The grpc team maintains a separate
repository as you noted.  I would prefer to keep everything together.  Frankly I think the
composer / packagist should have directives to ignore files as part of the specification. 
Most other packaging tools do.

> Add only PHP code to the packagist.org composer package
> -------------------------------------------------------
>
>                 Key: THRIFT-4804
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4804
>             Project: Thrift
>          Issue Type: Improvement
>          Components: PHP - Library
>    Affects Versions: 0.11.0, 0.12.0
>            Reporter: Michael C. Butler
>            Assignee: James E. King III
>            Priority: Minor
>
> We install apache/thrift PHP client library via composer (example: composer require apache/thrift:0.12)
and after installing, we noticed that the entire apache/thrift git repo is there, along with
all the C/C++, Go, Java, Python, and so on, code. Because composer and packagist are strictly
a PHP thing, is it possible to strip out the unrelated items to the packagist deployment?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message