From dev-return-54851-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Fri Jan 11 15:34:10 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6DDF3180676 for ; Fri, 11 Jan 2019 15:34:09 +0100 (CET) Received: (qmail 71422 invoked by uid 500); 11 Jan 2019 14:34:08 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 71411 invoked by uid 99); 11 Jan 2019 14:34:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Jan 2019 14:34:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id F2E51C00D6 for ; Fri, 11 Jan 2019 14:34:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.5 X-Spam-Level: X-Spam-Status: No, score=-109.5 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_SHORT=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 8d7uf8NkBuJt for ; Fri, 11 Jan 2019 14:34:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5D2086110D for ; Fri, 11 Jan 2019 14:28:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7D15DE2638 for ; Fri, 11 Jan 2019 14:28:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 39ECC2558B for ; Fri, 11 Jan 2019 14:28:00 +0000 (UTC) Date: Fri, 11 Jan 2019 14:28:00 +0000 (UTC) From: "Christopher Friedt (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (THRIFT-4593) Unit Tests failing on Alpine Linux due to non-portable mutex initializers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-4593?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D167= 40432#comment-16740432 ]=20 Christopher Friedt commented on THRIFT-4593: -------------------------------------------- Actually, the problem was with musl libc's implementation of getaddrinfo. I= actually submitted a patch to musl to correct it and drove the change to a= cceptance for the release of 1.1.20. See the mailing list https://goo.gl/8wb4fx Therefore, any Alpine Linux releases that are based on musl 1.1.20 or above= should build fine. Thanks for taking a look at this anyway, and good work with making the chan= ge to C++11. > Unit Tests failing on Alpine Linux due to non-portable mutex initializers > ------------------------------------------------------------------------- > > Key: THRIFT-4593 > URL: https://issues.apache.org/jira/browse/THRIFT-4593 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Affects Versions: 0.11.0 > Environment: Ubuntu Bionic (native) > alpine:latest (docker) > Reporter: Christopher Friedt > Assignee: James E. King III > Priority: Minor > Fix For: 1.0 > > > It seems that the lib/cpp/test suite is broken in the 0.11.0 tagged relea= se because this fails in Ubuntu Bionic and inside of an Alpine Linux 3.8 Do= cker container. > I would have thought all test suites would pass for tagged releases. > In any case, I've narrowed the culprits down to the non-portable (NP) cla= ss of Mutex initializers. > I'd rather not speculate at this point exactly why this problem is happen= ing. Currently my patching just disables those tests undonditionally, but t= here should probably be a better solution used in the end. E.g. better .m4 = testing for non-portable pthread features - if they are actually functional= or just stubs. > Currently, I'm working on automating builds of thrift for Alpine Linux 3.= 8, and they will likely require "make check" to pass successfully in future= versions. Might as well ensure it works now. > =C2=A0 > ``` > make[5]: Entering directory '/home/cfriedt/Desktop/thrift-20180627/lib/cp= p/test' > Running 54 test cases... > An error message from getaddrinfo on the console is expected: > Thrift: Wed Jun 27 20:16:03 2018 getaddrinfo -2: Name or service not know= n > *** No errors detected > PASS: UnitTests > Running 2 test cases... > Thrift: Wed Jun 27 20:16:10 2018 ~TFDTransport TTransportException: 'TFDT= ransport::close(): Bad file descriptor' > *** No errors detected > PASS: TFDTransportTest > Running 1 test case... > *** No errors detected > PASS: TPipedTransportTest > Running 3 test cases... > *** No errors detected > PASS: DebugProtoTest > Running 11 test cases... > *** No errors detected > PASS: JSONProtoTest > Running 17 test cases... > *** No errors detected > PASS: OptionalRequiredTest > Running 4 test cases... > *** No errors detected > PASS: RecursiveTest > Running 1 test case... > *** No errors detected > PASS: SpecializationTest > Running 3 test cases... > TBinaryProtocol =3D> OK > TLEBinaryProtocol =3D> OK > TCompactProtocol =3D> OK > *** No errors detected > PASS: AllProtocolsTest > Running 285 test cases... > Timeout alarm expired; attempting to unblock transport > Timeout alarm expired; attempting to unblock transport > Timeout alarm expired; attempting to unblock transport > Timeout alarm expired; attempting to unblock transport > Timeout alarm expired; attempting to unblock transport > ^CMakefile:1436: recipe for target 'check-TESTS' failed > make[5]: *** [check-TESTS] Interrupt > Makefile:1559: recipe for target 'check-am' failed > make[4]: *** [check-am] Interrupt > Makefile:1562: recipe for target 'check' failed > make[3]: *** [check] Interrupt > Makefile:1658: recipe for target 'check-recursive' failed > make[2]: *** [check-recursive] Interrupt > Makefile:580: recipe for target 'check-recursive' failed > make[1]: *** [check-recursive] Interrupt > Makefile:663: recipe for target 'check-recursive' failed > make: *** [check-recursive] Interrupt > ``` -- This message was sent by Atlassian JIRA (v7.6.3#76005)