From dev-return-54942-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Mon Jan 14 16:04:09 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6830B180718 for ; Mon, 14 Jan 2019 16:04:09 +0100 (CET) Received: (qmail 6087 invoked by uid 500); 14 Jan 2019 15:04:08 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 6065 invoked by uid 99); 14 Jan 2019 15:04:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Jan 2019 15:04:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 03C36180D59 for ; Mon, 14 Jan 2019 15:04:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id DSsQ6Ri3iHlu for ; Mon, 14 Jan 2019 15:04:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 1B9585F4E5 for ; Mon, 14 Jan 2019 15:04:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 283E8E2672 for ; Mon, 14 Jan 2019 15:04:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2ADF125641 for ; Mon, 14 Jan 2019 15:04:04 +0000 (UTC) Date: Mon, 14 Jan 2019 15:04:04 +0000 (UTC) From: "James E. King III (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (THRIFT-1759) for generated Obj-C constants, move static variable declarations in implementation file to 'static const' declarations in header file MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III resolved THRIFT-1759. --------------------------------------- Resolution: Won't Do Assignee: James E. King III Fix Version/s: 1.0 As support for the older cocoa compiler and library have been removed (see THRIFT-4719), all of the issues in Jira related to that code have also been removed. For legacy cocoa support you can use version 0.12.0 - everyone is expected to move to swift if they want to use the next release of Thrift. > for generated Obj-C constants, move static variable declarations in implementation file to 'static const' declarations in header file > ------------------------------------------------------------------------------------------------------------------------------------- > > Key: THRIFT-1759 > URL: https://issues.apache.org/jira/browse/THRIFT-1759 > Project: Thrift > Issue Type: Improvement > Components: Cocoa - Compiler > Affects Versions: 0.1, 0.9, 1.0 > Reporter: Paul Mans > Assignee: James E. King III > Priority: Minor > Fix For: 1.0 > > Attachments: t_cocoa_generator_const_static.patch > > > By declaring constants as 'static const' in the header file instead in of the implementation file we can use the constants in more places, such as in case statements of switch blocks. > Currently in Obj-C constants can only be accessed by using the static methods, which leads to some limitations. > The 'const' prefix only should apply to "primitive" constants (not structs or collections) -- This message was sent by Atlassian JIRA (v7.6.3#76005)