From dev-return-54508-archive-asf-public=cust-asf.ponee.io@thrift.apache.org Thu Jan 3 14:12:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 76E1518067A for ; Thu, 3 Jan 2019 14:12:04 +0100 (CET) Received: (qmail 20239 invoked by uid 500); 3 Jan 2019 13:12:03 -0000 Mailing-List: contact dev-help@thrift.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@thrift.apache.org Delivered-To: mailing list dev@thrift.apache.org Received: (qmail 20228 invoked by uid 99); 3 Jan 2019 13:12:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Jan 2019 13:12:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 294FBC2511 for ; Thu, 3 Jan 2019 13:12:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id unGRPi2orjv9 for ; Thu, 3 Jan 2019 13:12:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 729F160D94 for ; Thu, 3 Jan 2019 13:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8E8FAE2633 for ; Thu, 3 Jan 2019 13:12:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3FF3F253BC for ; Thu, 3 Jan 2019 13:12:00 +0000 (UTC) Date: Thu, 3 Jan 2019 13:12:00 +0000 (UTC) From: "James E. King III (JIRA)" To: dev@thrift.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (THRIFT-1362) Once we've looked up the Scheme once, there's no need to look it up again MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/THRIFT-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King III updated THRIFT-1362: -------------------------------------- Fix Version/s: (was: 1.0) > Once we've looked up the Scheme once, there's no need to look it up again > ------------------------------------------------------------------------- > > Key: THRIFT-1362 > URL: https://issues.apache.org/jira/browse/THRIFT-1362 > Project: Thrift > Issue Type: Improvement > Components: Java - Compiler > Affects Versions: 0.8 > Reporter: Bryan Duxbury > Assignee: Bryan Duxbury > Priority: Minor > > The first object that has the TProtocol version of write() or read() called should do the lookup, but after that, the scheme is known. Let's generate some overloads to write() and read() that take, for instance, TTupleProtocol so that we don't have to bother with doing the map lookup. -- This message was sent by Atlassian JIRA (v7.6.3#76005)